-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCC Bus #98
RCC Bus #98
Conversation
cc @TheZoq2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good to me, but is also lacking CHANGELOG entry.
Done. |
@TheZoq2 Would you mind lending me another pair of eyes here? |
Sure, I'll have a look at it after work in a few hours |
ping @TheZoq2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this looks good to me. Thanks!
It is not breaking change.