Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAC support #11

Merged
merged 9 commits into from
Jun 27, 2018
Merged

MAC support #11

merged 9 commits into from
Jun 27, 2018

Conversation

sstaub
Copy link
Contributor

@sstaub sstaub commented Jun 1, 2018

    1. This PR supports the internal MAC address like on mbed
    1. Changed init procedure like on Ethernet3 (https://github.com/sstaub/Ethernet3) library, it is now Ethernet.begin(ip, subnet, gateway, dns) which is more common
  • tested with STM32F429 Nucleo
  • tested with STM32F746 Discovery
  • updated readme.md and examples

@sstaub sstaub mentioned this pull request Jun 1, 2018
Closed
@fpistm fpistm self-requested a review June 1, 2018 11:47
@fpistm fpistm added the enhancement New feature or request label Jun 1, 2018
@fpistm
Copy link
Member

fpistm commented Jun 1, 2018

Thanks @sstaub
I will review it when I will have some time.
Anyway any external review are welcome ;)

fpistm
fpistm requested changes Jun 16, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/STM32Ethernet.cpp Outdated Show resolved Hide resolved
src/STM32Ethernet.cpp Outdated Show resolved Hide resolved
src/STM32Ethernet.h Outdated Show resolved Hide resolved
@sstaub
Copy link
Contributor Author

sstaub commented Jun 18, 2018 •
edited
Loading

I have made the requested changes to the API. Also made a better documentation and brought back
the original Arduino API.

@sstaub
Copy link
Contributor Author

sstaub commented Jun 20, 2018

done some small code optimization

fpistm
fpistm reviewed Jun 26, 2018
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove commented dead code and this will be ok to squash and merge.
Thanks

src/STM32Ethernet.cpp Outdated Show resolved Hide resolved
src/STM32Ethernet.cpp Outdated Show resolved Hide resolved
@sstaub
Copy link
Contributor Author

sstaub commented Jun 26, 2018

OK, it's done 😀

@fpistm fpistm merged commit fa66984 into stm32duino:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstaub @fpistm