fix: call effective ETH scheduler only from Timer callback #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict effective ETH scheduler to Timer callback only. This is to avoid any race condition on ETH scheduler, which could previously be called from timer ISR, as well as DHCP or UDP driver parts. Any direct request for ETH scheduler (direct call to stm32_eth_scheduler()) will generate a Timer Update Event to force a call to timer callback Fixes stm32duino#45 Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
fpistm
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: call effective ETH scheduler only from Timer callback
Restrict effective ETH scheduler to Timer callback only.
This is to avoid any race condition on ETH scheduler,
which could previously be called from timer ISR,
as well as DHCP or UDP driver parts.
Any direct request for ETH scheduler (direct call to stm32_eth_scheduler())
will generate a Timer Update Event to force a call to timer callback
Fixes #45