Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing stompjs dependency #543

Open
awallat opened this issue Oct 20, 2023 · 2 comments
Open

Missing stompjs dependency #543

awallat opened this issue Oct 20, 2023 · 2 comments

Comments

@awallat
Copy link

awallat commented Oct 20, 2023

After updating from rx-stomp 1.2.0 -> 2.0.0 my app is not running anymore and it complains about:

Error: node_modules/@stomp/rx-stomp/esm6/rx-stomp.d.ts:2:84 - error TS2307: Cannot find module '@stomp/stompjs' or its corresponding type declarations.

I saw that the stompjs-library is not there anymore and yarn (3.6.3) was giving this warning:

YN0002: │ xxxxxx@workspace:. doesn't provide @stomp/stompjs (pbbbdc), requested by @stomp/rx-stomp

image

Adding the latest stompjs lib (7.0.0) to my package.json fixes the issue.
Do I need to provide it manually with 2.0.0?

@kum-deepak
Copy link
Member

Many thanks for the report. Your solution is correct.

The dependency has been marked as a peerDependencies in v2.0.0 from dependencies in earlier versions. This is to avoid getting a duplicate copy of rxjs installed in a few cases.

The package manager should have ensured at least one copy is installed.

I will add that in a few cases, you may need to install dependencies explicitly.

@LeLunZ
Copy link

LeLunZ commented Jun 13, 2024

Same error happening here :)
package managers like npm don't install pear dependencies automatically. But npm usually gives warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants