Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #49 by adding rules for JSON Schema unevaluatedProperties keyword #50

Closed
wants to merge 3 commits into from
Closed

Fixes #49 by adding rules for JSON Schema unevaluatedProperties keyword #50

wants to merge 3 commits into from

Conversation

DavidBiesack
Copy link
Contributor

@DavidBiesack DavidBiesack commented Aug 17, 2023 •
edited
Loading

add rules for JSON Schema unevaluatedProperties keyword, similar to additionalProperties

Motivation and Context

Fixes #49

Description

Clone the rules

How Has This Been Tested?

Added a jest testcase

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@DavidBiesack
Copy link
Contributor Author

Can someone review this PR please?

@DavidBiesack
Copy link
Contributor Author

Can someone review this PR please?
I hope this project has not been abandoned.

@DavidBiesack
Copy link
Contributor Author

Still looking for a committer review of this.

( Note: merging and releasing this will help "fix" the deployment failure for #42 @P0lip )

@mnaumanali94
Copy link
Collaborator

@DavidBiesack I'll take a look at this today! Apologies for the delay

@DavidBiesack
Copy link
Contributor Author

@mnaumanali94 any updates?

@philsturgeon
Copy link
Contributor

Thanks for this @DavidBiesack, I'm merging it to my OWASP API Security 2023 pull request which the team have asked me to work on.

@philsturgeon philsturgeon mentioned this pull request Jan 21, 2024
Merged
@philsturgeon
Copy link
Contributor

Combined pull request with #51

@philsturgeon philsturgeon mentioned this pull request Jan 21, 2024
Open
9 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow schemas to use unevaluatedProperties: false instead of additionalProperties: false
3 participants
@DavidBiesack @mnaumanali94 @philsturgeon