Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop schemaPath function #1621

Closed
3 tasks
P0lip opened this issue May 12, 2021 · 1 comment · Fixed by #1633
Closed
3 tasks

Drop schemaPath function #1621

P0lip opened this issue May 12, 2021 · 1 comment · Fixed by #1633
Assignees
Labels
breaking Pull requests that introduce a breaking change tech-debt v6 Scheduled to be released in v6
Milestone

Comments

@P0lip
Copy link
Contributor

P0lip commented May 12, 2021

schemaPath function relies on Spectral's internals and is used only by AsyncAPI ruleset.

  • Remove the SchemaPath usage in AsyncAPI ruleset.
  • Create a custom function if we cannot use any other spectral function to achieve the same outcome.
  • Use the custom function in the AsyncAPI ruleset.
@P0lip P0lip added tech-debt breaking Pull requests that introduce a breaking change labels May 12, 2021
@P0lip P0lip changed the title Drop schemaPath function - Drop schemaPath function May 12, 2021
@P0lip P0lip added the v6 Scheduled to be released in v6 label May 12, 2021
@P0lip P0lip added this to the v6.0 milestone May 12, 2021
@philsturgeon
Copy link
Contributor

This is legacy left over from the old example validation code. It should be removed and asyncapi updated to not need it.

@P0lip P0lip self-assigned this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Pull requests that introduce a breaking change tech-debt v6 Scheduled to be released in v6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants