Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup plugin commonjs should be a dev dependency #2563

Open
1 task
w3nl opened this issue Dec 15, 2023 · 0 comments · May be fixed by #2564
Open
1 task

Rollup plugin commonjs should be a dev dependency #2563

w3nl opened this issue Dec 15, 2023 · 0 comments · May be fixed by #2564
Labels
chore triaged

Comments

@w3nl
Copy link

w3nl commented Dec 15, 2023 •
edited
Loading

@P0lip / @mnaumanali94

Chore summary
Rollup plugin commonjs is now a normal dependency, and is installed if you add @stoplight/spectral-ruleset-bundler to a project.
This will result in some unnecessary dependencies that are installed.

Tasks

  • Move @rollup/plugin-commonjs from devDependency to dependency

Additional context
Also fixes a Snyk issue of inflight
https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
@stoplight/spectral-ruleset-bundler@1.5.2 › @rollup/plugin-commonjs@25.0.7 › glob@8.1.0 › inflight@1.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ruleset-bundler): rollup plugin commonjs is a dev dependency w3nl/spectral
2 participants
@w3nl @mnaumanali94