fix(severity): default severity should be warning #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 591e3fb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.1% change). View more on Code Climate. |
|
the important piece that changed is https://github.com/stoplightio/spectral/pull/74/files#diff-105a25db2fd03476fc2d5672bc256a8cR87 the rest is just updating the snapshots to be correct |
lottamus
approved these changes
Dec 21, 2018
lottamus
pushed a commit
that referenced
this pull request
Dec 21, 2018
* Add files via upload * add logo * Add files via upload * Update README.md * Add files via upload * Update README.md * Delete spectral-banner.png * Delete spectral-banner-v3.png * Delete spectral-banner-left.png * add image folder with logo * add logo * update img * test(rules): update failing rules to use snapshots (#68) * fix(severity): default severity should be warning (#74) * fix(severitylabel): deafult severity label based on rule severity * fix(tests): update tests to use default warning severity * fix(ruleset): add rule type to path-keys-no-trailing-slash
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Current: if no
rule.severityalways default toValidationSeverity.ErrorExpected/Fixed: if no
rule.severityalways default to label corresponding toValidationSeverity.ErrorCurrent: if no
rule.severityLabelalways default toValidationSeverityLabel.WarnExpected/Fixed: if no
rule.severityLabelalways default to label corresponding torule.severityDoes this PR introduce a breaking change?
No