feat: add support for gateway race configuration via wrangler secret #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/add-dagula-gateway-to-staging
branch
2 times, most recently
from
1b78f54
to
41a312e
Compare
vasco-santos
force-pushed
the
feat/add-dagula-gateway-to-staging
branch
from
41a312e
to
e2aded9
Compare
alanshaw
requested changes
Oct 12, 2022
packages/edge-gateway/src/env.js
Outdated
| /** | ||
| * @param {string} input | ||
| */ | ||
| function getListFromInput (input) { |
There was a problem hiding this comment.
Suggested change
| function getListFromInput (input) { | |
| function parseGatewayUrls (json) { |
packages/edge-gateway/src/env.js
Outdated
| /** | ||
| * @param {Env} env | ||
| */ | ||
| function setGatewayRace (env) { |
There was a problem hiding this comment.
Suggested change
| function setGatewayRace (env) { | |
| function addGatewayRacersToEnv (env) { |
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos
force-pushed
the
feat/add-dagula-gateway-to-staging
branch
from
c0578ad
to
e5e877f
Compare
vasco-santos
force-pushed
the
feat/add-dagula-gateway-to-staging
branch
2 times, most recently
from
88b0c54
to
aa787a0
Compare
alanshaw
approved these changes
Oct 12, 2022
vasco-santos
force-pushed
the
feat/add-dagula-gateway-to-staging
branch
from
aa787a0
to
32e7359
Compare
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gateway race configuration via wrangler secret.
To avoid potential issues with setting up invalid secret, we validate and default to hardcoded values if given secret is not a valid one. For better observability, race configuration was added to
GET /versionand invalid values are logged.