fix: end error response should be gateway timeout or bad gateway #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure we should always say we timed out... If we timed out we should respond with 504 Gateway Timeout. If all requests errored then we should return 502 Bad Gateway. |
vasco-santos
changed the title
vasco-santos
force-pushed
the
fix/end-error-response-should-be-timeout
branch
2 times, most recently
from
6eb6bf7
to
0750412
Compare
vasco-santos
force-pushed
the
fix/end-error-response-should-be-timeout
branch
from
0750412
to
3c30b48
Compare
|
@alanshaw I agree and did a new iteration here. So now, if we get all race contestants to timeout we return 504 Gateway Timeout. If at least one fails without timeout we return 502 Bad Gateway. Needed to skip these 2 error codes in edge-gateway or these errors would get reported to Sentry |
This was referenced Nov 8, 2022
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If content is not resolved by any of the caching layers, nor gateway race tiers we currently return one of the errors from the public gateways in the race.
We should just return a gateway timeout / bad gateway error to the user instead. Alternatively, we could return a 404 but 404 looks less true representation of the error given we trigger timeouts on each race contestants
Closes #90