Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak #79

Closed
anjor opened this issue May 25, 2023 · 2 comments
Closed

Potential memory leak #79

anjor opened this issue May 25, 2023 · 2 comments
Assignees

Comments

@anjor
Copy link

anjor commented May 25, 2023

I was trying to upload a directory about ~18G in size using w3up yesterday

cid: bafybeiet7ksjxjgze64ujy3373gipvz2rornpbx6qowhbudwhsmfik32uy

and got following warnings:

⠋ Storing 55%(node:34318) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 101 abort listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit
⠙ Storing 55%(node:34318) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 101 abort listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit
⠙ Storing 55%(node:34318) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 102 abort listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit
@gobengo
Copy link
Contributor

gobengo commented Dec 8, 2023

@anjor I believe @alanshaw fixed this with
storacha/w3up#1227
and released with @web3-storage/upload-client@12.3.2 storacha/w3up#1228

I believe if you npm install -g @web3-storage/w3cli, the semver ranges on that package will pull in this latest upload-client with the memory leak fix. I tried it out and see lower memory usage.

@anjor When you use latest upload-client with this fix, do you no longer see the Possible EventTarget memory leak detected?

@gobengo gobengo self-assigned this Dec 8, 2023
@gobengo
Copy link
Contributor

gobengo commented Dec 13, 2023

@anjor Testing on our side seems to indicate this is fixed. Please reopen the issue if you can reproduce the issue and we'll take another look!

@gobengo gobengo closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants