-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(egress/record): rename capability #1572
Conversation
Signed-off-by: Felipe Forbeck <felipe.forbeck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, I don't think this is the way we should do this. There's no delegatation chain back to the user. All we're doing here is using UCAN to verify we can call microservices within our own stack, for which we could simply use a plain HTTP API and a bearer token.
From discord: It's important that the gateway is authorized to record egress. In a future where there are multiple decentralized gateways, there should be no other gateway able to record egress usage for a given space unless authorized to do so. There should be a delegation chain from the user to the gateway that authorizes it to track egress usage so that the user can be billed accordingly.
I'm loathed to approve this - we're going to have to undo it in the future.
Thanks for flagging this @alanshaw ! I've updated the code and renamed the capability to make it easy for us in the future. This is ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [18.1.1](upload-api-v18.1.0...upload-api-v18.1.1) (2024-11-05) ### Fixes * **egress/record:** rename capability ([#1572](#1572)) ([d28691c](d28691c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [16.4.1](w3up-client-v16.4.0...w3up-client-v16.4.1) (2024-11-05) ### Fixes * **egress/record:** rename capability ([#1572](#1572)) ([d28691c](d28691c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [17.4.1](capabilities-v17.4.0...capabilities-v17.4.1) (2024-11-05) ### Fixes * **egress/record:** rename capability ([#1572](#1572)) ([d28691c](d28691c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Felipe Forbeck <fforbeck@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [16.4.1](w3up-client-v16.4.0...w3up-client-v16.4.1) (2024-11-05) ### Fixes * **egress/record:** rename capability ([#1572](#1572)) ([d28691c](d28691c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update to
usage/record
CapabilityOverview
This PR restructures the
usage/record
capability, moving it under theSpace
namespace instead ofUsage
. As part of this change, theusage/record
definition has been renamed tospace/content/serve/egress/record
, and a new top-level capability,space/content/serve/*
, has been introduced.Key Changes
usage/record
capability now resides under theSpace
namespace.space/content/serve/egress/record
: This capability records egress for all served data.space/content/serve/*
: New top-level capability, representing general serve actions within theSpace.contentServe
namespace.