feat: allow tracking kafka produce and consume offsets #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
reviewed
Jun 28, 2023
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
|
I am not testing both, and 🤷 maybe. I figured I would test this on a project before release |
msutkowski
previously approved these changes
Jun 28, 2023
dydx
previously approved these changes
Jun 28, 2023
|
@msutkowski Alright, looking at the code again, I assert the second upsert case at the end of the test. We should be good to merge. |
msutkowski
approved these changes
Jul 10, 2023
btkostner
pushed a commit
that referenced
this pull request
Jul 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](v1.1.2...v1.2.0) (2023-07-10) ### Features * allow tracking kafka produce and consume offsets ([#18](#18)) ([ebab69b](ebab69b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the one remaining feature from the golang library that I haven't ported yet. Now it's done. It allows tracking Kafka offsets. Datadog uses this to detect lag and consumers that are offline and not reporting.
After every publish, we push the last offset to Datadog. After every consume, we push the last read offset to Datadog. It can then calculate the offset and alert us on issues.