fix: add case for error http status #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
previously approved these changes
Mar 30, 2023
|
So, we do log the error, though that's just text with the HTTP status. I guess we could log the whole thing though... Update: It should log the whole response as metadata now. |
samuelpordeus
approved these changes
Mar 30, 2023
This was referenced Mar 30, 2023
btkostner
pushed a commit
that referenced
this pull request
Apr 24, 2023
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-04-06) ### ⚠ BREAKING CHANGES * Package and application configuration is now under `data_streams` instead of `dd_data_streams` ### Features * add basic implementation of ddsketch ([#1](#1)) ([125b5ed](125b5ed)) * add basic kafka tracking support with data streams ([#3](#3)) ([bfc6a0b](bfc6a0b)) * add LICENSE file ([#11](#11)) ([6c5668f](6c5668f)) * link open telemetry span to current pathway context ([#5](#5)) ([e0ed9b2](e0ed9b2)) * rename dd_data_streams to data_streams ([#9](#9)) ([a0d1742](a0d1742)) ### Bug Fixes * add case for error http status ([#8](#8)) ([ef4a95d](ef4a95d)) * **ci:** update PR title regex check ([64ef99f](64ef99f)) * dialyzer warnings for kafka integration map ([18bf936](18bf936)) * filter out nil values from kafka integration tags ([b33926f](b33926f)) * update kafka integration to not set context on produce ([#7](#7)) ([6807b6d](6807b6d)) * update otel resource service configuration ([adb9890](adb9890)) * update tag logic to be more consistant ([#4](#4)) ([48d13df](48d13df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent a raised error like such:
Instead, it will catch the error and run
Logger.error("Error sending metrics to Datadog", error: error). While still noisy in logs, it should not show up in error reporters like Sentry or DataDog.