Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only regex a string #16

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: only regex a string #16

merged 2 commits into from
Jan 31, 2024

Conversation

twhitbeck
Copy link

For Shopify webhooks, authorization header is not present. We were trying to scrub nil by running it through a regex, which blows up.

Copy link

@vasspilka vasspilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I'm wondering wether we should just return nil when it's not binary instead of the scrub_value. Overall it seems to be specific to the "authentication" metadata key if we don't have it do we even want to set it to the scrub value?

@twhitbeck twhitbeck merged commit b13b235 into main Jan 31, 2024
7 checks passed
@twhitbeck twhitbeck deleted the tw/handle-missing-header branch January 31, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants