feat: support response body/headers logging on errors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Oct 16, 2024
| capture_io(:standard_error, fn -> | ||
| ErrorPlug.call(conn, []) | ||
| Logger.flush() | ||
| Process.sleep(10) |
There was a problem hiding this comment.
Does the test fail without Process.sleep(10)?
There was a problem hiding this comment.
Yea - looks like we can actually remove all of them. I can't see a reason as to why we have any of these in here outside of what was in the logger case from ~8 years ago? 🤔
zorbash
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be really nice if on error cases if we have the option of logging out the response body to making debugging a bit easier. I've set this to default to
trueas it makes sense to me, and should really only be turned off if you like pain.