Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing this plugin without @latest installs an unexpected version 2.0.2 #632

Closed
Barryrowe opened this issue Feb 9, 2017 · 3 comments

Comments

@Barryrowe
Copy link

We have been trying to use this plugin for simple steps (that we have used before) for a day now, getting odd results from functions.

We finally realized that the latest version here is 1.5.3, but the version cordova installed was 2.0.2.

If you just run:

```cordova plugin add cordova-sqlite-storage```

you end up with version 2.0.2 of the plugin somehow.

Here is the verbose output from that command:

barry$ cordova plugin add cordova-sqlite-storage --verbose
No scripts found for hook "before_plugin_add".
No version specified for cordova-sqlite-storage, retrieving version from config.xml
No version for cordova-sqlite-storage saved in config.xml
Attempting to use npm info for cordova-sqlite-storage to choose a compatible release
Running command: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Command finished with error code 0: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Calling plugman.fetch on plugin "cordova-sqlite-storage@2.0.2"
Fetching plugin "cordova-sqlite-storage@2.0.2" via npm
Copying plugin "/Users/barry/.cordova/lib/npm_cache/cordova-sqlite-storage/2.0.2/package" => "/Users/barry/git-repos/device-health-check/plugins/cordova-sqlite-storage"
Calling plugman.install on plugin "/Users/barry/git-repos/device-health-check/plugins/cordova-sqlite-storage" for platform "ios
Installing "cordova-sqlite-storage" for ios
Running command: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Command finished with error code 0: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Finding scripts for "before_plugin_install" hook from plugin cordova-sqlite-storage on ios platform only.
Executing script found in plugin cordova-sqlite-storage for hook "before_plugin_install": plugins/cordova-sqlite-storage/scripts/beforePluginInstall.js
Resolving module name for q => q
installing external dependencies via npm
npm install of external dependencies ok
Install start for "cordova-sqlite-storage" on ios.
Beginning processing of action stack for ios project...
Action stack processing complete.
Install complete for cordova-sqlite-storage on ios.
Finding scripts for "after_plugin_install" hook from plugin cordova-sqlite-storage on ios platform only.
No scripts found for hook "after_plugin_install".
No scripts found for hook "after_plugin_add".

If we run:

```cordova plugin add cordova-sqlite-storage@latest```

we get the right version of 1.5.3.

Verbose output from this:

barry$ cordova plugin add cordova-sqlite-storage@latest --save --verbose
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "cordova-sqlite-storage@latest"
Fetching plugin "cordova-sqlite-storage@latest" via npm
Copying plugin "/Users/barry/.cordova/lib/npm_cache/cordova-sqlite-storage/1.5.3/package" => "/Users/barry/git-repos/device-health-check/plugins/cordova-sqlite-storage"
Calling plugman.install on plugin "/Users/barry/git-repos/device-health-check/plugins/cordova-sqlite-storage" for platform "ios
Installing "cordova-sqlite-storage" for ios
Running command: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Command finished with error code 0: /Users/barry/git-repos/device-health-check/platforms/ios/cordova/version 
Finding scripts for "before_plugin_install" hook from plugin cordova-sqlite-storage on ios platform only.
Executing script found in plugin cordova-sqlite-storage for hook "before_plugin_install": plugins/cordova-sqlite-storage/scripts/beforePluginInstall.js
Resolving module name for q => q
installing external dependencies via npm
npm install of external dependencies ok
Install start for "cordova-sqlite-storage" on ios.
Beginning processing of action stack for ios project...
Action stack processing complete.
Install complete for cordova-sqlite-storage on ios.
Finding scripts for "after_plugin_install" hook from plugin cordova-sqlite-storage on ios platform only.
No scripts found for hook "after_plugin_install".
Saved plugin info for "cordova-sqlite-storage" to config.xml
No scripts found for hook "after_plugin_add".

Cordova Version: 6.4.0

@brodycj
Copy link
Contributor

brodycj commented Feb 9, 2017

Yes, this is because of how we resolved #580 (support VS 2015 and VS 2017 out of the box). See also: #599 (Windows 10 issue), #615 (master vs edge question)

I hope to fix this soon. For now this is only an issue in case of Windows 10 on VS 2015 or VS 2017.

@mirko77
Copy link

mirko77 commented Mar 23, 2017

@brodybits this does not affect Android (4.4+) and iOS (8+), right? I have a build with 2.0.2 from 1.4.5 which I will have to revoke if it is going to break

@brodycj
Copy link
Contributor

brodycj commented Mar 23, 2017

@brodybits this does not affect Android (4.4+) and iOS (8+), right?

Correct, more details in: #615 (comment)

This will be fixed soon. Moving further discussion to #615.

@brodycj brodycj closed this as completed Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants