Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects iterator should use SUBSTRING function in SQL query #56

Closed
mniewrzal opened this issue Dec 13, 2021 · 3 comments
Closed

Objects iterator should use SUBSTRING function in SQL query #56

mniewrzal opened this issue Dec 13, 2021 · 3 comments

Comments

@mniewrzal
Copy link
Collaborator

The issue is fixed in CRDB v20.2.5, which is already deployed on all satellites.

[https://github.com/cockroachdb/cockroach/issues/57367|https://github.com/cockroachdb/cockroach/issues/57367|smart-link]
Migrated from https://storjlabs.atlassian.net/browse/PG-176
@mniewrzal
Copy link
Collaborator Author

Commented by Michal Niewrzal

https://review.dev.storj.io/c/storj/storj/+/4052

@mniewrzal
Copy link
Collaborator Author

Commented by Michal Niewrzal

substring_in_listing_query.txt

I attached listing results from metabase-benchmark tool that compares current implementation and it looks that using SUBSTRING query directly in SQL query doesn’t affect performance in a negative way.

@mniewrzal
Copy link
Collaborator Author

Done with https://review.dev.storj.io/c/storj/storj/+/8356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mniewrzal