Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests? #70

Closed
dstroot opened this issue Aug 23, 2019 · 2 comments · Fixed by #74
Closed

Run tests? #70

dstroot opened this issue Aug 23, 2019 · 2 comments · Fixed by #74
Assignees
@kylesuss
Labels
released

Comments

@dstroot
Copy link

dstroot commented Aug 23, 2019

In package.json the tests reference react-scripts:

    "test": "cross-env CI=1 react-scripts test --env=jsdom",
    "test:watch": "react-scripts test --env=jsdom"

But react-scripts are not installed. How are y'all runnin yo tests?
@kylesuss kylesuss mentioned this issue Sep 3, 2019
Merged
@kylesuss
Copy link
Collaborator

kylesuss commented Sep 3, 2019

@dstroot Nice catch. I suspect those scripts were ported over from another project. We don't have any tests right now, so I am just going to remove those until we do.

@kylesuss
Copy link
Collaborator

🚀 Issue was released in v1.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylesuss kylesuss

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused test scripts storybookjs/design-system
2 participants
@dstroot @kylesuss