Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example does not work with latest remark-gfm@4.0.0 #45

Open
zcolleyz opened this issue Oct 5, 2023 · 1 comment
Open

Example does not work with latest remark-gfm@4.0.0 #45

zcolleyz opened this issue Oct 5, 2023 · 1 comment

Comments

@zcolleyz
Copy link

zcolleyz commented Oct 5, 2023

Describe the bug
Example does not work with latest remark-gfm version 4.0.0. When you run it you get the following error:

#41 41.33 Module build failed (from ./node_modules/@storybook/mdx2-csf/loader.js):
#41 41.33 TypeError: Cannot read properties of undefined (reading 'inTable')
#41 41.33     at Object.exitCodeText (./node_modules/mdast-util-gfm-table/lib/index.js:82:17)
#41 41.33     at compile3 (./node_modules/@storybook/mdx2-csf/dist/index.js:95356:41)
#41 41.33     at fromMarkdown (./node_modules/@storybook/mdx2-csf/dist/index.js:95215:29)
#41 41.33     at parser (./node_modules/@storybook/mdx2-csf/dist/index.js:95936:12)
#41 41.33     at Function.parse9 [as parse] (./node_modules/@storybook/mdx2-csf/dist/index.js:81475:12)
#41 41.33     at executor (./node_modules/@storybook/mdx2-csf/dist/index.js:81535:31)
#41 41.33     at new Promise (<anonymous>)
#41 41.33     at Function.process3 [as process] (./node_modules/@storybook/mdx2-csf/dist/index.js:81530:14)
#41 41.33     at compile (./node_modules/@storybook/mdx2-csf/dist/index.js:101897:35)
#41 41.33     at compile2 (./node_modules/@storybook/mdx2-csf/dist/index.js:102304:30)
#41 41.33     at Object.loader (./node_modules/@storybook/mdx2-csf/loader.js:29:20)

To Reproduce
Steps to reproduce the behavior:

  1. Install remark-gfm at 4.0.0
  2. Apply the config from the documentation for @storybook/addon-docs
  3. Run Storybook
  4. See an error

Expected behavior

Runs as it did with v3.0.1

Additional context

This was tested through @storybook/addon-docs and so I don't know if the bug should be raised there instead, this seemed to be what consumes remarkPlugins

@vekunz
Copy link

vekunz commented Oct 26, 2023

We have this error as well. This blocks updating remark-gfm to 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants