Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vite-plugin-solid as a peerDependencies for frameworks/solid-vite #4

Open
sudoaugustin opened this issue Dec 4, 2023 · 0 comments
Open

Add vite-plugin-solid as a peerDependencies for frameworks/solid-vite #4

sudoaugustin opened this issue Dec 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@sudoaugustin
Copy link

Describe the bug

U have imported vite-plugin-solid on runtime here. But in the package.json file u have specified it only as a devDependencies. So when we install your package via npm, vite-plugin-solid (which require on production) wasn't been installed by npm since it's only marked as dev dependency.

Screenshots and/or logs

Screenshot 2023-12-04 at 11 06 59 PM
@sudoaugustin sudoaugustin added the bug Something isn't working label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sudoaugustin