From 6031e88276245c5f1e8a1c3af38fcdef4bc7a855 Mon Sep 17 00:00:00 2001 From: Qazzian Date: Tue, 1 Oct 2019 17:36:51 +0100 Subject: [PATCH 1/2] Fix custom themes breaking the welcome demo. Having applied a dark theme to storybook I noticed that the react demo sets the background white but does not set the text color. This resulted in white text (from my custom theme) rendered on a white background. This change will make the text readable --- app/react/src/demo/Welcome.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/app/react/src/demo/Welcome.tsx b/app/react/src/demo/Welcome.tsx index 20c3bb0313f3..64dd824a9881 100644 --- a/app/react/src/demo/Welcome.tsx +++ b/app/react/src/demo/Welcome.tsx @@ -9,6 +9,7 @@ const Main = (props?: React.DetailedHTMLProps, lineHeight: 1.4, fontFamily: '"Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif', backgroundColor: '#fff', + color: '#000', }} /> ); From 0f44a31b21af6bc10065e0593dbaf01c9ad0752e Mon Sep 17 00:00:00 2001 From: Qazzian Date: Wed, 2 Oct 2019 23:34:29 +0100 Subject: [PATCH 2/2] Update welcome page snapshots --- .../stories/__snapshots__/storyshot.enzyme.test.js.snap | 1 + .../storyshot.snapshotWithOptionsFunction.test.js.snap | 1 + .../required_with_context/__snapshots__/Welcome.stories.foo | 1 + .../__snapshots__/Welcome.stories.storyshot | 1 + 4 files changed, 4 insertions(+) diff --git a/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap b/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap index cae5deca1852..52e623917a4d 100644 --- a/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap +++ b/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.enzyme.test.js.snap @@ -121,6 +121,7 @@ exports[`Storyshots Welcome to Storybook 1`] = ` style={ Object { "backgroundColor": "#fff", + "color": "#000", "fontFamily": "\\"Helvetica Neue\\", Helvetica, \\"Segoe UI\\", Arial, freesans, sans-serif", "lineHeight": 1.4, "padding": 15, diff --git a/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap b/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap index dd98d76c66d5..5ced7dcd8ce0 100644 --- a/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap +++ b/addons/storyshots/storyshots-core/stories/__snapshots__/storyshot.snapshotWithOptionsFunction.test.js.snap @@ -101,6 +101,7 @@ exports[`Storyshots Welcome to Storybook 1`] = ` style={ Object { "backgroundColor": "#fff", + "color": "#000", "fontFamily": "\\"Helvetica Neue\\", Helvetica, \\"Segoe UI\\", Arial, freesans, sans-serif", "lineHeight": 1.4, "padding": 15, diff --git a/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo b/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo index 1fda01fe66a0..5691a19203ff 100644 --- a/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo +++ b/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.foo @@ -5,6 +5,7 @@ exports[`Storyshots Welcome to Storybook 1`] = ` style={ Object { "backgroundColor": "#fff", + "color": "#000", "fontFamily": "\\"Helvetica Neue\\", Helvetica, \\"Segoe UI\\", Arial, freesans, sans-serif", "lineHeight": 1.4, "padding": 15, diff --git a/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot b/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot index 1fda01fe66a0..5691a19203ff 100644 --- a/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot +++ b/addons/storyshots/storyshots-core/stories/required_with_context/__snapshots__/Welcome.stories.storyshot @@ -5,6 +5,7 @@ exports[`Storyshots Welcome to Storybook 1`] = ` style={ Object { "backgroundColor": "#fff", + "color": "#000", "fontFamily": "\\"Helvetica Neue\\", Helvetica, \\"Segoe UI\\", Arial, freesans, sans-serif", "lineHeight": 1.4, "padding": 15,