From d63dec18a2fb6fe8132137460109fac2c2cabcf4 Mon Sep 17 00:00:00 2001 From: fazulk Date: Mon, 23 Jan 2023 09:24:25 -0800 Subject: [PATCH 1/3] fix: update vue2 script --- code/lib/cli/src/sandbox-templates.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts index c6b26f5e4c39..6d0a95df4efc 100644 --- a/code/lib/cli/src/sandbox-templates.ts +++ b/code/lib/cli/src/sandbox-templates.ts @@ -165,11 +165,7 @@ const baseTemplates = { }, 'vue2-vite/2.7-js': { name: 'Vue2 Vite (vue 2.7 JS)', - // TODO: convert this to an `npm create` script, use that instead. - // We don't really want to maintain weird custom scripts like this, - // preferring community bootstrap scripts / generators instead. - script: - 'yarn create vite . --template vanilla && yarn add --dev @vitejs/plugin-vue2 vue-template-compiler vue@2 && echo "import vue2 from \'@vitejs/plugin-vue2\';\n\nexport default {\n\tplugins: [vue2()]\n};" > vite.config.js', + script: 'npx create-vue@2 {{beforeDir}} --default', // Re-enable once https://github.com/storybookjs/storybook/issues/19351 is fixed. skipTasks: ['smoke-test'], expected: { From 9b8cf2ede65a845edf06a46d719209d82c929221 Mon Sep 17 00:00:00 2001 From: fazulk Date: Mon, 23 Jan 2023 10:02:55 -0800 Subject: [PATCH 2/3] chore: set to inDevelopment --- code/lib/cli/src/sandbox-templates.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts index 6d0a95df4efc..3580fb7c0696 100644 --- a/code/lib/cli/src/sandbox-templates.ts +++ b/code/lib/cli/src/sandbox-templates.ts @@ -166,6 +166,7 @@ const baseTemplates = { 'vue2-vite/2.7-js': { name: 'Vue2 Vite (vue 2.7 JS)', script: 'npx create-vue@2 {{beforeDir}} --default', + inDevelopment: true, // Re-enable once https://github.com/storybookjs/storybook/issues/19351 is fixed. skipTasks: ['smoke-test'], expected: { From 5acc55f7209a8d2a3df5852c71b0a8b37dc64d43 Mon Sep 17 00:00:00 2001 From: Yann Braga Date: Mon, 30 Jan 2023 19:06:48 +0100 Subject: [PATCH 3/3] CI: fix parallelism count --- .circleci/config.yml | 10 +++++----- code/lib/cli/src/sandbox-templates.ts | 4 ++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 00f3a552e09a..1e29f7a93b0d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -630,25 +630,25 @@ workflows: requires: - build - create-sandboxes: - parallelism: 27 + parallelism: 26 requires: - build # - smoke-test-sandboxes: # disabled for now # requires: # - create-sandboxes - build-sandboxes: - parallelism: 27 + parallelism: 26 requires: - create-sandboxes - test-runner-sandboxes: - parallelism: 27 + parallelism: 26 requires: - build-sandboxes - chromatic-sandboxes: - parallelism: 27 + parallelism: 26 requires: - build-sandboxes - e2e-sandboxes: - parallelism: 27 + parallelism: 26 requires: - build-sandboxes diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts index 3580fb7c0696..d42ac30a008f 100644 --- a/code/lib/cli/src/sandbox-templates.ts +++ b/code/lib/cli/src/sandbox-templates.ts @@ -166,6 +166,7 @@ const baseTemplates = { 'vue2-vite/2.7-js': { name: 'Vue2 Vite (vue 2.7 JS)', script: 'npx create-vue@2 {{beforeDir}} --default', + // TODO: reenable this once sandbox is available inDevelopment: true, // Re-enable once https://github.com/storybookjs/storybook/issues/19351 is fixed. skipTasks: ['smoke-test'], @@ -354,6 +355,7 @@ const baseTemplates = { 'qwik-vite/default-ts': { name: 'Qwik CLI (Default TS)', script: 'yarn create qwik basic {{beforeDir}} --no-install', + // TODO: reenable this once sandbox is available inDevelopment: true, skipTasks: ['e2e-tests'], expected: { @@ -373,6 +375,7 @@ const internalTemplates = { 'internal/ssv6-vite': { ...baseTemplates['react-vite/default-ts'], name: 'StoryStore v6 (react-vite/default-ts)', + // TODO: reenable this once sandbox is available inDevelopment: true, isInternal: true, modifications: { @@ -386,6 +389,7 @@ const internalTemplates = { 'internal/ssv6-webpack': { ...baseTemplates['react-webpack/18-ts'], name: 'StoryStore v6 (react-webpack/18-ts)', + // TODO: reenable this once sandbox is available inDevelopment: true, isInternal: true, modifications: {