diff --git a/MIGRATION.md b/MIGRATION.md
index 7eb83edaf83c..cb0df4acf69e 100644
--- a/MIGRATION.md
+++ b/MIGRATION.md
@@ -31,6 +31,7 @@
- [--use-npm flag in storybook CLI](#--use-npm-flag-in-storybook-cli)
- [`setGlobalConfig` from `@storybook/react`](#setglobalconfig-from-storybookreact)
- [StorybookViteConfig type from @storybook/builder-vite](#storybookviteconfig-type-from-storybookbuilder-vite)
+ - [props from WithTooltipComponent from @storybook/components](#props-from-withtooltipcomponent-from-storybookcomponents)
- [From version 7.5.0 to 7.6.0](#from-version-750-to-760)
- [CommonJS with Vite is deprecated](#commonjs-with-vite-is-deprecated)
- [Using implicit actions during rendering is deprecated](#using-implicit-actions-during-rendering-is-deprecated)
@@ -591,6 +592,20 @@ The `StorybookViteConfig` type is now removed in favor of `StorybookConfig`:
import type { StorybookConfig } from '@storybook/react-vite';
```
+#### props from WithTooltipComponent from @storybook/components
+
+The deprecated properties `tooltipShown`, `closeOnClick`, and `onVisibilityChange` of `WithTooltipComponent` from `@storybook/components` are now removed. Please replace them:
+
+```tsx
+
+ ...
+
+```
+
## From version 7.5.0 to 7.6.0
#### CommonJS with Vite is deprecated
diff --git a/code/addons/themes/src/theme-switcher.tsx b/code/addons/themes/src/theme-switcher.tsx
index 4fc7ffa89256..7e366fe8359e 100644
--- a/code/addons/themes/src/theme-switcher.tsx
+++ b/code/addons/themes/src/theme-switcher.tsx
@@ -57,7 +57,7 @@ export const ThemeSwitcher = () => {
{
return (
{
+ // this is mostly to fix flakiness in chromatic, specifically on Safari
+ // where the scrollbar appears inconsistently and causes the snapshot to be different
+ await waitFor(
+ async () => {
+ const iframeEl = canvasElement.querySelector('iframe');
+ await expect(
+ iframeEl!.contentDocument!.querySelector('[data-testid="sb-iframe-text"]')
+ ).toBeVisible();
+ },
+ { timeout: 10000 }
+ );
+ },
};
export const IFrameWithParameter: Story = {
diff --git a/code/ui/blocks/src/examples/SimpleSizeTest.tsx b/code/ui/blocks/src/examples/SimpleSizeTest.tsx
index 72e43ab45855..34021666c625 100644
--- a/code/ui/blocks/src/examples/SimpleSizeTest.tsx
+++ b/code/ui/blocks/src/examples/SimpleSizeTest.tsx
@@ -12,7 +12,7 @@ export const SimpleSizeTest = () => {
margin: '-4rem -20px',
}}
>
-
+
This story does nothing. Its only purpose is to show how its size renders in different
conditions (inline/iframe/fixed height) when used in a {''} block.
diff --git a/code/ui/components/package.json b/code/ui/components/package.json
index 148a6097ae54..74d3f290d88a 100644
--- a/code/ui/components/package.json
+++ b/code/ui/components/package.json
@@ -72,6 +72,7 @@
"devDependencies": {
"@popperjs/core": "^2.6.0",
"@radix-ui/react-scroll-area": "^1.0.5",
+ "@storybook/test": "workspace:*",
"@types/react-syntax-highlighter": "11.0.5",
"@types/util-deprecate": "^1.0.0",
"css": "^3.0.0",
diff --git a/code/ui/components/src/components/tooltip/WithTooltip.stories.tsx b/code/ui/components/src/components/tooltip/WithTooltip.stories.tsx
index 76eab8d7c113..8ccb459095a0 100644
--- a/code/ui/components/src/components/tooltip/WithTooltip.stories.tsx
+++ b/code/ui/components/src/components/tooltip/WithTooltip.stories.tsx
@@ -1,6 +1,7 @@
import type { FunctionComponent, ComponentProps } from 'react';
import React from 'react';
import type { StoryObj } from '@storybook/react';
+import { expect, screen } from '@storybook/test';
import { styled } from '@storybook/theming';
import { TooltipMessage } from './TooltipMessage';
import { WithToolTipState as WithTooltip } from './WithTooltip';
@@ -104,6 +105,9 @@ export const SimpleClickStartOpen: StoryObj>
Click me!
),
+ play: async () => {
+ await expect(await screen.findByText('Lorem ipsum dolor sit')).toBeInTheDocument();
+ },
};
export const SimpleClickCloseOnClick: StoryObj> = {
diff --git a/code/ui/components/src/components/tooltip/WithTooltip.tsx b/code/ui/components/src/components/tooltip/WithTooltip.tsx
index bece4bc64278..e76c898d6dd0 100644
--- a/code/ui/components/src/components/tooltip/WithTooltip.tsx
+++ b/code/ui/components/src/components/tooltip/WithTooltip.tsx
@@ -36,18 +36,6 @@ export interface WithTooltipPureProps
tooltip: ReactNode | ((p: WithHideFn) => ReactNode);
children: ReactNode;
onDoubleClick?: () => void;
- /**
- * @deprecated use `defaultVisible` property instead. This property will be removed in SB 8.0
- */
- tooltipShown?: boolean;
- /**
- * @deprecated use `closeOnOutsideClick` property instead. This property will be removed in SB 8.0
- */
- closeOnClick?: boolean;
- /**
- * @deprecated use `onVisibleChange` property instead. This property will be removed in SB 8.0
- */
- onVisibilityChange?: (visibility: boolean) => void | boolean;
/**
* If `true`, a click outside the trigger element closes the tooltip
* @default false
@@ -68,9 +56,6 @@ const WithTooltipPure: FC = ({
children,
closeOnTriggerHidden,
mutationObserverOptions,
- closeOnClick,
- tooltipShown,
- onVisibilityChange,
defaultVisible,
delayHide,
visible,
@@ -94,15 +79,12 @@ const WithTooltipPure: FC = ({
{
trigger,
placement,
- defaultVisible: defaultVisible ?? tooltipShown,
+ defaultVisible,
delayHide,
interactive,
- closeOnOutsideClick: closeOnOutsideClick ?? closeOnClick,
+ closeOnOutsideClick,
closeOnTriggerHidden,
- onVisibleChange: (_isVisible) => {
- onVisibilityChange?.(_isVisible);
- onVisibleChange?.(_isVisible);
- },
+ onVisibleChange,
delayShow,
followCursor,
mutationObserverOptions,
diff --git a/code/yarn.lock b/code/yarn.lock
index 91d091fbedac..d97a6fb453c3 100644
--- a/code/yarn.lock
+++ b/code/yarn.lock
@@ -5070,6 +5070,7 @@ __metadata:
"@storybook/icons": "npm:^1.2.1"
"@storybook/manager-api": "workspace:*"
"@storybook/preview-api": "workspace:*"
+ "@storybook/test": "workspace:*"
"@storybook/theming": "workspace:*"
"@storybook/types": "workspace:*"
"@types/color-convert": "npm:^2.0.0"
@@ -5343,6 +5344,7 @@ __metadata:
"@storybook/csf": "npm:^0.1.2"
"@storybook/global": "npm:^5.0.0"
"@storybook/icons": "npm:^1.2.1"
+ "@storybook/test": "workspace:*"
"@storybook/theming": "workspace:*"
"@storybook/types": "workspace:*"
"@types/react-syntax-highlighter": "npm:11.0.5"