Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version all events #10576

Closed
2 tasks
tmeasday opened this issue Apr 28, 2020 · 3 comments
Closed
2 tasks

Version all events #10576

tmeasday opened this issue Apr 28, 2020 · 3 comments

Comments

@tmeasday
Copy link
Member

  • Ensure all events have a v:1 field
  • Check when receiving an event it either has no v field (SB5 or less), or v==1. If it has a higher version number, log a warning that the event may not be handled correctly.

This is for refs in particular (in the future we may connect to SB7+ iframes), but also for addon compatibility.

@ndelangen suggested v:6 to start. I'm OK with that, but we wouldn't want to change it to v:7 in SB7 unless the event payload changed. So it might get confusing. I'm not sure.

@ndelangen
Copy link
Member

@tmeasday after giving it some more thought, i think having a v:1 is better. versioning storybook separately from the event versions seems fair to me.

@shilman shilman modified the milestones: 6.0, 6.0 args May 8, 2020
@shilman shilman modified the milestones: 6.0 args, 6.1 Jun 12, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 3, 2020
@stale
Copy link

stale bot commented Aug 2, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants