Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in root path detection. #10847

Closed
christianwiedemann opened this issue May 20, 2020 · 1 comment
Closed

Typo in root path detection. #10847

christianwiedemann opened this issue May 20, 2020 · 1 comment
Milestone

Comments

@christianwiedemann
Copy link
Contributor

Describe the bug
There is a typo 'node-modules' instead of node_modules in root detection in lib/core/src/server/config/utils.js in storybook 6.x

To Reproduce
Steps to reproduce the behavior:

  1. Start storybook without .git or .svn folder in root. You got an "Module parse failed: Unexpected token (9:31)" because the babel loader did not include the right root.

Expected behavior
Start and compile js and jsx files correctly.

Code snippets
result = result || __dirname.split('node-modules')[0]; should be result = result || __dirname.split('node_modules')[0];

A PR will follow.

@shilman
Copy link
Member

shilman commented May 22, 2020

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.13 containing PR #10848 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants