Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF: Forbid duplicate kinds #11108

Closed
shilman opened this issue Jun 10, 2020 · 2 comments
Closed

CSF: Forbid duplicate kinds #11108

shilman opened this issue Jun 10, 2020 · 2 comments
Assignees
@shilman
Labels
BREAKING CHANGE core csf
Milestone
6.0 breaking

Comments

@shilman
Copy link
Member

shilman commented Jun 10, 2020

What

Forbid duplicate kinds and throw a warning when we see it, effectively reverting #8133

Why

This feature has caused HMR issues since it was released and we don't have a good solution.

This is a breaking change. If users want to break up their stories into multiple files, we'll propose they create a single story file per kind/component and re-export stories from sub-files.
@shilman shilman added this to the 6.0 breaking milestone Jun 10, 2020
@shilman shilman self-assigned this Jun 10, 2020
@shilman shilman mentioned this issue Jun 10, 2020
Merged
@shilman shilman mentioned this issue Jun 19, 2020
Closed
@shilman shilman mentioned this issue Jul 1, 2020
Merged
2 tasks
@shilman
Copy link
Member Author

shilman commented Jul 2, 2020

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.39 containing PR #11369 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 2, 2020
@shilman shilman mentioned this issue Jul 9, 2020
Merged
3 tasks
@shilman
Copy link
Member Author

shilman commented Jul 10, 2020

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-rc.2 containing PR #11476 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
BREAKING CHANGE core csf
Projects
None yet
Milestone
6.0 breaking
Development

No branches or pull requests
1 participant
@shilman