Double render when first enter web-app

[Stupidism]

This may cause confusions for components cares about render times.
I found this bug in my own demo project.

how to reproduce

Click the link above first.
If I enter homepage first and then come to component page, they are rendered once.

But if I refresh in component page(or enter component page directly), they are rendered twice.

expected

Components should only be rendered once in both situations above

[Stupidism]

@shilman I think this happens because the url is updated after first render?

[shilman]

@Stupidism Hmm that could be it. Mind testing it out—I'd do it myself but your demo project seems to be offline. If you're right, it shouldn't happen when you navigate directly to the final URL. Please let me know what you find, and if it's due to the redirect then I'd say this isn't actually a bug.

[Stupidism]

@shilman Sorry, the above link is updated now.

[shilman]

Hmm it looks like the double-render happens even when the URL is not updated?

[Stupidism]

@shilman Also, it renders twice when HMR

[Stupidism]

@shilman It always calls the render function twice when both first-enter and HMR.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!