Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-docs] Links in headings have smaller font-size than text #11393

Closed
ajkl2533 opened this issue Jul 2, 2020 · 3 comments
Closed

[addon-docs] Links in headings have smaller font-size than text #11393

ajkl2533 opened this issue Jul 2, 2020 · 3 comments

Comments

@ajkl2533
Copy link
Contributor

ajkl2533 commented Jul 2, 2020

Describe the bug
When using a link in heading in the MDX file than the link and text have different font-size. I suspect that the issue is coming from here where is hardcoded the 14px font-size for links, instead, there should be probable inherited because the size of the link should be probably inherited from an element in which is placed.

To Reproduce
Create MDX file with:

# [Link](#test) Text

## [Link](#test) Text

Expected behavior
Links should have the same font size as the text in the heading

Screenshots
Screenshot 2020-07-02 at 17 44 33

Code snippets

# [Link](#test) Text

## [Link](#test) Text

System:

  System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 12.13.1 - ~/.nvm/versions/node/v12.13.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - ~/Documents/PROJECTS/ambrosia-design-system/node_modules/.bin/npm
  Browsers:
    Chrome: 83.0.4103.116
    Safari: 13.1
  npmPackages:
    @storybook/addon-actions: ^6.0.0-beta.38 => 6.0.0-beta.39 
    @storybook/addon-docs: ^6.0.0-beta.38 => 6.0.0-beta.39 
    @storybook/addon-storyshots: ^6.0.0-beta.38 => 6.0.0-beta.39 
    @storybook/addon-storyshots-puppeteer: ^6.0.0-beta.38 => 6.0.0-beta.39 
    @storybook/react: ^6.0.0-beta.38 => 6.0.0-beta.39 
    @storybook/theming: ^6.0.0-beta.38 => 6.0.0-beta.39 
@stale
Copy link

stale bot commented Jul 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 25, 2020
@ajkl2533
Copy link
Contributor Author

@shilman Any update on this?

@shilman
Copy link
Member

shilman commented Aug 3, 2020

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-rc.24 containing PR #11770 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants