Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 6.0.16 shows unnecessary upgrade message #12183

Closed
trustthe27 opened this issue Aug 21, 2020 · 11 comments
Closed

Storybook 6.0.16 shows unnecessary upgrade message #12183

trustthe27 opened this issue Aug 21, 2020 · 11 comments
Assignees

Comments

@trustthe27
Copy link

Describe the bug
Storybook 6.0.16 displays itself as Storybook 6.0.15 and offers to upgrade, even if it is the latest version.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'your-storybook/?path=/settings/about'
  2. See upgrade message

Expected behavior
Confirmation, that I'm at the latest version, without any upgrade options.

Screenshots

Screenshot for Storybook 6.0.16:

image

System:

System:
OS: macOS 10.15.6
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Binaries:
Node: 14.8.0 - /usr/local/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.7 - /usr/local/bin/npm
Browsers:
Chrome: 84.0.4147.135
Firefox: 78.0.2
Safari: 13.1.2
npmPackages:
@storybook/addon-a11y: ^6.0.16 => 6.0.16
@storybook/addon-actions: ^6.0.16 => 6.0.16
@storybook/addon-backgrounds: ^6.0.16 => 6.0.16
@storybook/addon-knobs: ^6.0.16 => 6.0.16
@storybook/addon-links: ^6.0.16 => 6.0.16
@storybook/addon-viewport: ^6.0.16 => 6.0.16
@storybook/addons: ^6.0.16 => 6.0.16
@storybook/preset-create-react-app: ^3.1.4 => 3.1.4
@storybook/react: ^6.0.16 => 6.0.16

@ndelangen
Copy link
Member

@shilman is versions.json outdated on docs page?

@shilman
Copy link
Member

shilman commented Aug 24, 2020

@ndelangen Looks fine to me

https://storybook.js.org/versions.json

Seems like a bug in the version storage? It knows the latest version is available, it just doesn't know it's already on the latest version.

@ndelangen
Copy link
Member

maybe this wasn't updated when you released?

export const version = '6.0.16';

@shilman shilman assigned shilman and unassigned ndelangen Aug 24, 2020
@AlanGreene
Copy link

Seeing the same thing with 6.0.18 reporting itself as 6.0.17.

@shilman
Copy link
Member

shilman commented Aug 26, 2020

argh. thought i fixed that in the publishing script. will give it another try on 6.0.19.

@stale
Copy link

stale bot commented Sep 20, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@cone56
Copy link
Contributor

cone56 commented Oct 21, 2020

This still isn't fixed. I'm running 6.0.26 which is reporting itself as 6.0.25 on the 'about' page.

@Spielboerg
Copy link
Contributor

In v6.1.18 the version number is off by 5 patch versions:

Bildschirmfoto 2021-02-18 um 08 40 45@2x

@Cheddam
Copy link

Cheddam commented Mar 31, 2021

Bumping - still an issue when running Storybook 6.2.0:

image

@shilman shilman added P0 and removed P3 labels Mar 31, 2021
@shilman shilman added this to the 6.2 stabilization milestone Mar 31, 2021
@shilman
Copy link
Member

shilman commented Mar 31, 2021

I fixed this in the release process. Versions 6.2.1 and above should no longer exhibit this behavior.

@shilman shilman closed this as completed Mar 31, 2021
@Cheddam
Copy link

Cheddam commented Apr 13, 2021

Hitting this again on Storybook 6.2.7 😕

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants