Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe glob resolutions before passing to webpack #12792

Open
shilman opened this issue Oct 16, 2020 · 3 comments
Open

De-dupe glob resolutions before passing to webpack #12792

shilman opened this issue Oct 16, 2020 · 3 comments

Comments

@shilman
Copy link
Member

shilman commented Oct 16, 2020

Originally posted by @ndelangen in #3968 (comment)

Interesting @felipenmoura . So the idea is that when you have multiple globs that resolve to the same story, some race condition is triggered that blows up the startup time?

I'm hoping that in the future, we don't rely on webpack's require.context at all anymore, and we resolve the globs (and can de-dup them) in node before starting webpack.

Sounds that might resolve that issue @shilman ?

@ndelangen that it would. it might also help with #12771 ?

@ndelangen
Copy link
Member

I don't really see a reason to think it would fix #12771 but I'm also not ruling it out.

@shilman shilman modified the milestones: 6.1 perf, 6.2 perf Nov 4, 2020
@shilman shilman added the P2 label Nov 4, 2020
@shilman
Copy link
Member Author

shilman commented Nov 4, 2020

Maybe we just warn about this rather than actually de-dupe?

@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@shilman shilman modified the milestones: 6.2 perf, 7.0 performance May 20, 2022
@stale stale bot removed inactive labels May 20, 2022
@shilman shilman removed the P2 label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants