Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls not behaving correctly in docs view #14374

Closed
yannbf opened this issue Mar 29, 2021 · 5 comments
Closed

Addon-controls not behaving correctly in docs view #14374

yannbf opened this issue Mar 29, 2021 · 5 comments

Comments

@yannbf
Copy link
Member

yannbf commented Mar 29, 2021

Hey peeps this contribution is super awesome! I wanted to show something I noticed while testing controls on docs page.
Here's the link to the story

I hope you don't mind the QA:

1 - the input is not as responsive as it could be, and text is not correctly aligned
2 - when playing with the picker, there's a flicker
3 - the color swatch feature is registering invalid colors as you type them (and says "black" for some reason)

Here's a gif showing these points:
2021-03-24 at 16 33 24 - Lime Giraffe

Edit: if you type an invalid color, the swatch allows to play with the hue, resulting in NaN:
image

cc ghengeveld EvHaus

Originally posted by yannbf in #14249 (comment)

┆Issue is synchronized with this Asana task by Unito

@shilman shilman added this to the 6.2 blocking milestone Mar 29, 2021
@ghengeveld ghengeveld self-assigned this Mar 29, 2021
@EvHaus
Copy link
Contributor

EvHaus commented Mar 29, 2021

@ghengeveld if you don't get to it this week, I can jump on this by Friday

@yannbf
Copy link
Member Author

yannbf commented Mar 29, 2021

I also noticed something else related to controls, although not related to the color picker. This might be quite simple so maybe there's no need to add an extra issue, however if you feel there is, I can create the issue!

For numeric enums, controls is identifying as objects and presenting the "RAW" toggle:
image

Clicking on it does nothing. That can be seen in next angular cli examples

@shilman
Copy link
Member

shilman commented Mar 30, 2021

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-rc.12 containing PR #14382 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@ghengeveld
Copy link
Member

@yannbf I addressed your other issues here: #14392

@shilman
Copy link
Member

shilman commented Mar 30, 2021

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-rc.13 containing PR #14392 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants