Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon/knobs] JSX Support #1580

Closed
thomask-gh opened this issue Aug 2, 2017 · 7 comments
Closed

[addon/knobs] JSX Support #1580

thomask-gh opened this issue Aug 2, 2017 · 7 comments

Comments

@thomask-gh
Copy link

thomask-gh commented Aug 2, 2017

It would be great if the knobs add-on had the ability to input simple JSX (img tags, etc.).

For instance: I have a coponent. One of its attributes is an object containing JSX, in this case an img tag. I'd like to be able to modify the img tag from the Knobs panel in Storybook. However, it seems that in order to do so, I'd need to have a function similar to for instance object but that allows to pass JSX.

@ndelangen
Copy link
Member

Can you elaborate?

@thomask-gh
Copy link
Author

I updated the issue description 😉

@Hypnosphi
Copy link
Member

Hypnosphi commented Aug 3, 2017

The most obvious use case is a component that expects children

@stale
Copy link

stale bot commented Oct 31, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. We do try to do some housekeeping every once in a while so inactive issues will get closed after 90 days. Thanks!

@stale stale bot added the inactive label Oct 31, 2017
@Hypnosphi Hypnosphi self-assigned this Oct 31, 2017
@stale stale bot removed the inactive label Oct 31, 2017
@Hypnosphi
Copy link
Member

Hypnosphi commented Oct 31, 2017

I think I'll add babel parsing to object knob after #1460 gets merged. But we need to find a way to prevent XSS first

@stale
Copy link

stale bot commented Dec 15, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Dec 15, 2017
@stale
Copy link

stale bot commented Dec 30, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants