Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs: allow opting out of persisting values in URL #1680

Closed
Hypnosphi opened this issue Aug 18, 2017 · 5 comments
Closed

Knobs: allow opting out of persisting values in URL #1680

Hypnosphi opened this issue Aug 18, 2017 · 5 comments

Comments

@Hypnosphi
Copy link
Member

Ideally it would be a per-knob option. In fact, maybe having this on object knob could be enough

@danielduan
Copy link
Member

I think the knobs in the URL looks really messy. I'd love to have an input in the panel to generate the copy and paste url, and perhaps save the actual knobs data in the local storage or cookie.

@SuperOl3g
Copy link
Contributor

Yep, with encoded Russian symbols it looks awful)
http://localhost:3001/?knob-%D0%A2%D0%B5%D0%BA%D1%81%D1%82=%D0%97%D0%B0%20%D0%BE%D0%B1%D0%B5%D0%B4.%20%D0%A1%D0%BF%D0%B0%D1%81%D0%B8%D0%B1%D0%BE%21&selectedKind=a.Balloon&selectedStory=%D0%91%D0%B5%D0%B7%20%D0%BF%D0%B0%D1%80%D0%B0%D0%BC%D0%B5%D1%82%D1%80%D0%BE%D0%B2&full=0&down=1&left=1&panelRight=0&downPanel=storybooks%2Fstorybook-addon-knobs

@stale
Copy link

stale bot commented Nov 30, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 30, 2017
@stale stale bot removed the inactive label Nov 30, 2017
@stale
Copy link

stale bot commented Jan 14, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Jan 14, 2018
@stale
Copy link

stale bot commented Jan 29, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants