Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-transform-regenerator and babel-plugin-transform-runtime missing from app/react/package.json #1729

Closed
vjpr opened this issue Aug 24, 2017 · 4 comments

Comments

@vjpr
Copy link

vjpr commented Aug 24, 2017

I assume in the other projects (app/vue) too.

@valscion
Copy link
Contributor

Seems like this was introduced by #1668? https://github.com/storybooks/storybook/pull/1668/files#r133578294

@valscion
Copy link
Contributor

valscion commented Sep 15, 2017

Here is a reproduction repository for this issue, created with create-react-app and just running getstorybook:

https://github.com/valscion/storybook-repro-1729

EDIT:

I used npm@2.x version for this repository to highlight how the @storybook/react package specifically has missing dependencies. Due to how npm > 3 and yarn install packages to root-level if possible, this issue isn't as obvious.

I'll work on a fix and then push a branch to my reproduction repository to highlight the fix

@Hypnosphi
Copy link
Member

@valscion Please create a PR as soon as you do that =)

@valscion
Copy link
Contributor

PR to fix this issue is here: #1848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants