Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon-info throws contrast accessibility issues for all stories #1878

Closed
camsloanftc opened this issue Sep 21, 2017 · 4 comments
Closed

addon-info throws contrast accessibility issues for all stories #1878

camsloanftc opened this issue Sep 21, 2017 · 4 comments
Labels
addon: info good first issue help wanted

Comments

@camsloanftc
Copy link

The contrast ratio for the addon-info "show info" button is inaccessible, and thus when used side-by-side with storybooks-addon-a11y, I now receive an error on every single story.

screen shot 2017-09-21 at 1 35 49 pm
@camsloanftc
Copy link
Author

darkening the background of the button to this hex color would become AA and AAA compliant: #155884

@Hypnosphi
Copy link
Member

@camsloanftc #155884 looks OK to me, feel free to submit a PR with corresponding change

@usulpro
Copy link
Member

usulpro commented Sep 23, 2017

possible better to wait when we move it to the panel: no such buttons at all!

@camsloanftc
Copy link
Author

If it is all being moved to the panel, then even better!

@dependencies dependencies bot mentioned this issue Feb 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: info good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hypnosphi @usulpro @camsloanftc