Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Measure tool stays active when switching to Docs, causing it to measure the Docs page. #21327

Closed
yannbf opened this issue Mar 1, 2023 · 3 comments

Comments

@yannbf
Copy link
Member

yannbf commented Mar 1, 2023

Describe the bug

Reported by @kbrandwijk (Thank you!)

The measure tool stays active when switching to Docs, causing it to measure the Docs page.

image

⚠️ Additionally, the Measure addon functionality, even though there is no button to enable it in docs mode, can be enabled via keyboard shortcuts. When it's enabled, it can't be disabled via keyboard shortcuts anymore.

To Reproduce

  • Run Storybook 7 with addon-essentials
  • Open a story, toggle measure on (press M or the addon icon)
  • Switch to docs

System

No response

Additional context

No response

@Dev79844
Copy link

Dev79844 commented Apr 3, 2023

Hey
I would like to work on this issue. Can you assign it to me?

@shilman
Copy link
Member

shilman commented May 10, 2023

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.15 containing PR #21602 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@yannbf yannbf closed this as completed May 10, 2023
@shilman
Copy link
Member

shilman commented May 12, 2023

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #21602 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants