Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: IconButton should be in active state when corresponding menu is open #21463

Closed
MichaelArestad opened this issue Mar 7, 2023 · 5 comments · Fixed by #21622
Closed

[Bug]: IconButton should be in active state when corresponding menu is open #21463

MichaelArestad opened this issue Mar 7, 2023 · 5 comments · Fixed by #21622
Labels
bug good first issue ui

Comments

@MichaelArestad
Copy link
Contributor

Describe the bug

Right now, the button reverts to a resting state when the corresponding menu is open making it hard to distinguish what the menu correlates to.

image /

This is something a bit more complex than styling so I could use some help with it.

@yannbf Thank you for spotting this

To Reproduce

No response

System

No response

Additional context

No response
@yannbf yannbf added ui and removed needs triage labels Mar 7, 2023
@shilman shilman moved this to Nice to have in Core Team Projects Mar 8, 2023
@MichaelArestad
Copy link
Contributor Author

This is definitely one I consider necessary for 7.0.

@ghidersamihaela
Copy link
Contributor

Hi. Is anyone working on this? I can take a look.

@MichaelArestad
Copy link
Contributor Author

@ghidersamihaela Please take a look! If you create a PR, definitely mention me.

@ghidersamihaela
Copy link
Contributor

@MichaelArestad sure, working on it.

@ghidersamihaela ghidersamihaela mentioned this issue Mar 15, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Nice to have to Done in Core Team Projects Mar 17, 2023
@pratikkarad pratikkarad mentioned this issue Mar 18, 2023
Closed
@shilman
Copy link
Member

shilman commented Mar 20, 2023

¡Ay Caramba!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.5 containing PR #21622 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue ui
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed IconButton to be in active state when corresponding menu is open
4 participants
@shilman @MichaelArestad @yannbf @ghidersamihaela