-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: npx sb@next upgrade --prerelease fails #21872
Comments
After a bit of debugging, it seems like the upgrade code tries to run the following action using spawn.sync:
And from what I noticed was that More investigation yielded that the NPM command was killed by SIGTERM, I have no idea why. Even more investigation. I modified the code to print the output from NPM:
I seems like spawn sync has a default output buffer of 200kb (https://stackoverflow.com/questions/63796633/spawnsync-bin-sh-enobufs), maybe it would be better to change the call to async (not sure if it would solve it) or don't pipe the output at all. Furthermore, the error was not at all printed to the console, so the pipe got lost in the way. |
i face same issues with next.js 13 "devDependencies": {
"@babel/core": "^7.21.4",
"@storybook/addon-actions": "^7.0.1",
"@storybook/addon-essentials": "^7.0.1",
"@storybook/addon-interactions": "^7.0.1",
"@storybook/addon-links": "^7.0.1",
"@storybook/addon-mdx-gfm": "^7.0.1",
"@storybook/nextjs": "^7.0.1",
"@storybook/react": "^7.0.1",
"@storybook/testing-library": "^0.1.0",
"babel-loader": "^8.3.0",
"eslint-plugin-storybook": "^0.6.11",
"storybook": "^7.0.1"
} |
Same for me |
+1 Also happening to me
|
This was added in here: 106b68f#diff-d0f1791b397d5217ce251c489ba1f69d64230e5850d03a380d1bc2ed687b7e0cR38 We also face this issue and the migration worked for me when I used |
Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.0 containing PR #21947 that references this issue. Upgrade today to the
|
This still results in ELSPROBLEMS |
@valentinpalkovic what do you think we should do? |
Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.3 containing PR #21947 that references this issue. Upgrade today to the
|
@shilman Still not working with 7.0.3. |
@yannbf Could you take another look at the implementation of |
@rebeljoi Have you executed |
@valentinpalkovic Yes. To me it looks like problem is that this line will still throw an error that isn't caught. |
Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.2 containing PR #22039 that references this issue. Upgrade today to the
|
Hello, I run that command and I got this error:
|
Same error @carlosrsabreu, try running |
Yeah, it worked! 🚀 Thank you! |
Resolved also the same error on my code-base. |
Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.4 containing PR #22039 that references this issue. Upgrade today to the
|
@valentinpalkovic So in the PR #22039, it looks like the error is being ignored. i.e. would there be a case where |
I ran the new command and the error still occurs.
|
Describe the bug
On an existing SB repo, I tried to upgrade from RC to 7 by running the upgrade action.
Here is the result:
To Reproduce
No response
System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: