Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getstorybook changes package.json indentation from tabs to spaces #2205

Closed
tansongyang opened this issue Nov 1, 2017 · 6 comments
Closed

Comments

@tansongyang
Copy link

Steps

  1. mkdir test-proj
  2. cd test-proj
  3. npm init. Keep all defaults.
  4. Convert spaces in package.json to tabs.
  5. npm install react
  6. getstorybook --use-npm

Result

package.json now has spaces.

Expected

package.json should still have tabs.

@danielduan
Copy link
Member

We don't actually write to your package.json. That's npm
npm/npm#4718

You should switch to yarn or upgrade to npm5.

@tansongyang
Copy link
Author

I see. Thanks for clearing that up.

@Hypnosphi
Copy link
Member

We don't actually write to your package.json.

That's actually not true at the moment: https://github.com/storybooks/storybook/blob/master/lib/cli/generators/REACT/index.js#L16-L18

@danielduan
Copy link
Member

is this a bug that we should fix?

@danielduan danielduan added the bug label Nov 1, 2017
@stale
Copy link

stale bot commented Dec 16, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Dec 16, 2017
@stale
Copy link

stale bot commented Dec 31, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants