Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Storybook off of Komposer/Mantra/Podda stack #2313

Closed
danielduan opened this issue Nov 15, 2017 · 5 comments
Closed

Refactor Storybook off of Komposer/Mantra/Podda stack #2313

danielduan opened this issue Nov 15, 2017 · 5 comments
Assignees
Labels
maintenance User-facing maintenance tasks ui
Milestone

Comments

@danielduan
Copy link
Member

These packages have not been maintained for a while. As a stop gap measure, I've published the offending packages to silence some peer dependency warnings. #2303

@danielduan danielduan added this to the v3.4.0 milestone Nov 15, 2017
@shilman shilman modified the milestones: v3.4.0, v4.0.0 Feb 3, 2018
@Hypnosphi Hypnosphi self-assigned this Apr 1, 2018
@Hypnosphi
Copy link
Member

Actually, we use redux in core/client for managing selected story, so we just need to move all the other state management there

@Hypnosphi
Copy link
Member

Hypnosphi commented Apr 1, 2018

Ok, I just realized that redux in core manages state in preview, and Kadira stack does it in manager. So it will be a separate store, but we can extract some shared helpers anyway

@danielduan
Copy link
Member Author

I have second thoughts about even refactoring off this stack.

I spent a good few hours trying to understand how the state management and containers work within the @storybook/ui package. It doesn't seem like I can migrate things little by little, and it's a huge effort that'd be better spent just starting fresh with a new UI like the SBNext project.

@Hypnosphi Hypnosphi modified the milestones: v4.0.0, next May 27, 2018
@ndelangen ndelangen mentioned this issue Aug 27, 2018
82 tasks
@ndelangen ndelangen modified the milestones: next, v5.0.0 Oct 13, 2018
@ndelangen
Copy link
Member

WIP #4086

@shilman
Copy link
Member

shilman commented Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

No branches or pull requests

5 participants