Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Typescript to >=v4.2 #23622

Closed
vanessayuenn opened this issue Jul 26, 2023 · 0 comments · Fixed by #25548
Closed

Pin Typescript to >=v4.2 #23622

vanessayuenn opened this issue Jul 26, 2023 · 0 comments · Fixed by #25548

Comments

@vanessayuenn
Copy link
Contributor

Currently, our package.json suggests we support all versions of typescript:

^ That is not entirely true since we have a dependency on type-fest@2 that supports typescript >=4.2 only.

That said, in order to keep up with the ecosystem and set expectations with users, we should be more explicit and specific with which typescript version we support. Since this will be a breaking change, 8.0 will be an opportunity for us to make this change.

Context: this came up when we discussed how to resolve #23554

@vanessayuenn vanessayuenn added this to the 8.0 breaking changes milestone Jul 26, 2023
@vanessayuenn vanessayuenn reopened this Jan 4, 2024
@vanessayuenn vanessayuenn moved this to Empathy Backlog in Core Team Projects Jan 5, 2024
@vanessayuenn vanessayuenn changed the title Pin Typescript to v5 Pin Typescript to >=v4.2 Jan 9, 2024
@vanessayuenn vanessayuenn moved this from Empathy Backlog to Ready for work in Core Team Projects Jan 9, 2024
@github-project-automation github-project-automation bot moved this from Empathy - Ready for work to Done in Core Team Projects Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants