Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate upgrading monorepo to Yarn 4 #24552

Closed
1 task
vanessayuenn opened this issue Oct 23, 2023 · 1 comment · Fixed by #24565
Closed
1 task

Investigate upgrading monorepo to Yarn 4 #24552

vanessayuenn opened this issue Oct 23, 2023 · 1 comment · Fixed by #24565
Assignees

Comments

@vanessayuenn
Copy link
Contributor

vanessayuenn commented Oct 23, 2023

Tasks

Pnp Support

As of https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#api-changes, there are changes regarding the pnp API. In the past, we already tried out the release candidate v4.x of @yarnpkg/libzip, which dropped Node v.16 support. This was the reason to roll back to v3. We should verify whether our implementation of pnp support still works with yarn v4.

@JReinhold
Copy link
Contributor

I've tested mealdrop with Yarn PnP both in v3 and v4, and they seem to behave identical, with the same errors.

Both cases errors with package dependencies missing so I had to manually add them and then it "worked".

So this is still not perfect but it seems like nothing has changed between v3 and v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants