Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated props from Canvas block #25339

Closed
Tracked by #25331
yannbf opened this issue Dec 27, 2023 · 5 comments · Fixed by #25459
Closed
Tracked by #25331

Remove deprecated props from Canvas block #25339

yannbf opened this issue Dec 27, 2023 · 5 comments · Fixed by #25459
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Dec 27, 2023

It's unclear whether to remove these deprecated properties from the Canvas block component in Storybook 8:

* @deprecated multiple stories are not supported

@JReinhold please let us know whenever you can 🙏

@shilman
Copy link
Member

shilman commented Dec 28, 2023

@JReinhold I think we should have a way to do docs-only stories before we remove this. I think I'm pretty close to having something here for 8.0 -- we just need to sit down and agree on some stuff. I can probably code it up in a day once we do. If we can't make that happen for some reason I suggest we punt on this until 9.0.

@JReinhold
Copy link
Contributor

@shilman I guess your reason being that the new props only allow for a single story, meaning that users wanting multi-story canvases are left out? Unless we provide a way to write docs-only stories, which would be referencable by the Canvas block as a single story?

I can get behind that.

@shilman
Copy link
Member

shilman commented Jan 4, 2024

Exactly @JReinhold

@yannbf
Copy link
Member Author

yannbf commented Jan 4, 2024

I'll leave it up to you @shilman, feel free to close this issue as unplanned if it won't work out!

@shilman
Copy link
Member

shilman commented Jan 8, 2024

I've implemented an approach to hiding stories from the sidebar #25328, and am confident we can get it into 8.0. Therefore we can move forward with this removal! 🚀

@shilman shilman removed their assignment Jan 8, 2024
@shilman shilman changed the title Determine whether to remove deprecated props from Canvas block Remove deprecated props from Canvas block Jan 8, 2024
@valentinpalkovic valentinpalkovic self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants