Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Number controls do not reset #25819

Closed
vanessayuenn opened this issue Jan 30, 2024 · 2 comments · Fixed by #26372
Closed

[Bug]: Number controls do not reset #25819

vanessayuenn opened this issue Jan 30, 2024 · 2 comments · Fixed by #26372
Labels
addon: controls bug good first issue help wanted sev:S3
Milestone
8.0-nice to have

Comments

@vanessayuenn
Copy link
Contributor

Describe the bug

Project: MealDrop
Version: 8.0.0-alpha.14
Bug/feedback:

Number controls do not reset:

reported here #25687

To Reproduce

  1. Go to https://stackblitz.com/edit/github-cde8qu?file=src%2Fstories%2FButton.jsx,src%2Fstories%2FButton.stories.js&preset=node
  2. Visit a Button story
  3. Define value for the age control
  4. Reset it
  5. Same issue happens in ArgsTable in autodocs

System

No response

Additional context

No response
@vanessayuenn vanessayuenn added this to the 8.0-Stable milestone Jan 30, 2024
@chakAs3
Copy link
Contributor

chakAs3 commented Jan 30, 2024 •
edited
Loading

I remember fixing this in this PR #22912 , it was closed without merge
https://github.com/storybookjs/storybook/blob/69c92f8eacca8c0cc89cef24d1ee5c03249ed018/code/ui/blocks/src/controls/Number.tsx

@ghidersamihaela
Copy link
Contributor

Hi, I would like to look into this.Thanks.

@jiyiru jiyiru mentioned this issue Mar 7, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: controls bug good first issue help wanted sev:S3
Projects
No open projects
Storybook 8.0 Roadmap
Status: Done
Milestone
8.0-nice to have
Development

Successfully merging a pull request may close this issue.

Controls: Fix number controls do not reset jiyiru/storybook
3 participants
@chakAs3 @vanessayuenn @ghidersamihaela