Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: migrate command does not escape filenames #26429

Closed
YukiKitagata opened this issue Mar 12, 2024 · 0 comments · Fixed by #26430
Closed

[Bug]: migrate command does not escape filenames #26429

YukiKitagata opened this issue Mar 12, 2024 · 0 comments · Fixed by #26430

Comments

@YukiKitagata
Copy link
Contributor

Describe the bug

An error occurs when executing the migrate command for a file whose path contains parentheses.
This is because jscodeshift does not perform filename escaping and the filename is given as an argument.

To Reproduce

Repository to reproduce: https://github.com/YukiKitagata/sb-migrate-escape-repro

It occurs just by targeting the folder containing the parentheses to the migrate command.

System

Storybook Environment Info:
  System:
    OS: macOS 14.1.2
    CPU: (10) arm64 Apple M1 Max
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.3.0 - ~/.volta/tools/image/node/21.3.0/bin/node
    Yarn: 1.22.19 - ~/.volta/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/21.3.0/bin/npm <----- active
    pnpm: 8.7.4 - ~/.volta/bin/pnpm
  Browsers:
    Chrome: 122.0.6261.112
    Safari: 17.1.2

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants