master tests not passing

[kn0ll]

first i'd like to say... apologies for this issue... all signs would suggest this is very much my problem and not storybook's...

Issue details

• What did you expect to happen?

on a fresh checkout, i expected the tests to pass.

• What happened instead?

the tests did not pass. instead they fail with snapshot errors, seemingly always involving dates. some dates seem to be off by a day (January 20, 2017 vs January 19, 2017)-- i could imagine this has something to do with regenerating snapshots? forgive me, i am unfamiliar with snapshot testing. but other dates are actually correct, only parsed and displayed differently (2017-1-20 vs 1/20/2017). which is a little more suspicious, no? you can find the full output of my tests here: https://gist.github.com/kn0ll/49cbca55faffe74fe1aee40229135521

Steps to reproduce

git clone git@github.com:storybooks/storybook.git
cd storybook
yarn install
yarn bootstrap --all
yarn test --core

Please specify which version of Storybook and optionally any affected addons that you're running

commit f8bd011e7374ff65f442aa1a8e6963f2d8d2b85d (HEAD -> master, origin/master, origin/HEAD)

Affected platforms

• macOS 10.13.2 (17C205)
• node v9.4.0
• yarn 1.3.2
• node_modules versions

[Hypnosphi]

@tmeasday this looks related to your change in date displaying

[tmeasday]

@Hypnosphi - remind me, did we end up fixing that on the other issue?

Also weird with the locale printing the date differently. I would propose we just change this test to print out the date as a timestamp or something; we really don't need to test JS date formatting in our tests ;)

[Hypnosphi]

did we end up fixing that on the other issue

Not really

I think we should just set both locale and timeyone explicitly everywhere we display a date

[tmeasday]

Hopefully this helps: #2861

[tmeasday]

@kn0ll can you try latest master please?

[tvooo]

Had the same issue last week. Can confirm the tests now pass with a fresh checkout of master. Thanks!

[kn0ll]

seeing the same issue. will check again this evening to make sure it's not loading old linked module or something.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!