Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper windows support. #300

Closed
arunoda opened this issue Jul 6, 2016 · 5 comments
Closed

Add proper windows support. #300

arunoda opened this issue Jul 6, 2016 · 5 comments
Labels

Comments

@arunoda
Copy link
Member

arunoda commented Jul 6, 2016

Seems like we use some bash features. See: #145
We need to add some proper support for windows.

cc @mnmtanish

@arunoda arunoda added the bug label Jul 6, 2016
@thani-sh
Copy link
Contributor

thani-sh commented Jul 7, 2016

I think we can use shelljs to write scripts so it'll work on all platforms. Eg. prepublish.js instead of prepublish.sh.

I'm working on integrating Appetize.io to react-native-storybook these days. I'll get back to react-storybook as soon as it's ready.

@arunoda
Copy link
Member Author

arunoda commented Jul 8, 2016

@mnmtanish sounds like a good plan.

@szopenkrk
Copy link

Its possible to fix that soon ?

@wallslide
Copy link

It's working for me on Windows now. Thanks!

@thani-sh
Copy link
Contributor

Fixed with #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants