Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Support custom bootstrap options #3193

Closed
amcdnl opened this issue Mar 12, 2018 · 4 comments
Closed

[angular] Support custom bootstrap options #3193

amcdnl opened this issue Mar 12, 2018 · 4 comments

Comments

@amcdnl
Copy link
Member

amcdnl commented Mar 12, 2018

Request

In Angular, the bootstrapModule function accepts options such as preserveWhitespaces. Docs: https://angular.io/api/core/PlatformRef#bootstrapModule

Example:

platformBrowserDynamic().bootstrapModule(AppModule, {
    preserveWhitespaces: false
});

I'd like the ability to pass options it accepts to this function here: https://github.com/storybooks/storybook/blob/master/app/angular/src/client/preview/angular/helpers.ts#L126

@alterx
Copy link
Member

alterx commented Mar 13, 2018

Yeah, I think we should add a bootstrapOptions field to the story

@stale
Copy link

stale bot commented Apr 6, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 6, 2018
@stale
Copy link

stale bot commented May 6, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@shilman
Copy link
Member

shilman commented May 18, 2021

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-alpha.31 containing PR #14852 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants