Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest code coverage with storyshots (Angular) #3289

Closed
michaelgeorgeattard opened this issue Mar 26, 2018 · 10 comments
Closed

Jest code coverage with storyshots (Angular) #3289

michaelgeorgeattard opened this issue Mar 26, 2018 · 10 comments

Comments

@michaelgeorgeattard
Copy link

michaelgeorgeattard commented Mar 26, 2018

When using imageSnapshot test with storyshots, is it possible to get accurate coverage numbers?

With renderOnly I am getting the accurate numbers:

import initStoryshots, { renderOnly } from "@storybook/addon-storyshots";

initStoryshots({
    suite: "Image storyshots",
    test: renderOnly
});

However with imageSnapshot I am getting wrong coverage numbers:

import initStoryshots, { imageSnapshot } from "@storybook/addon-storyshots";

initStoryshots({
    suite: "Image storyshots",
    test: imageSnapshot({})
});

I am generating the image snapshots on a running instance of the playground.

@stale
Copy link

stale bot commented Apr 16, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 16, 2018
@michaelgeorgeattard
Copy link
Author

Any updates on this please?

@stale stale bot removed the inactive label Apr 18, 2018
@stale
Copy link

stale bot commented May 9, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 9, 2018
@Hypnosphi
Copy link
Member

cc @igor-dv

@stale stale bot removed the inactive label May 9, 2018
@stale
Copy link

stale bot commented May 30, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 30, 2018
@Hypnosphi
Copy link
Member

cc @thomasbertet

@stale stale bot removed the inactive label Jun 8, 2018
@stale
Copy link

stale bot commented Jun 29, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 29, 2018
@stale
Copy link

stale bot commented Jul 29, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jul 29, 2018
@penx
Copy link
Contributor

penx commented Feb 28, 2019

+1 for a documented way of getting code coverage output from storybook stories

@penx
Copy link
Contributor

penx commented Feb 28, 2019

that's a pretty aggressive stalebot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants